use Icon in almost all the places #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
measureTextWidth returns numberPreview: documentation | landing | table |
|
pls fix conflicts |
Merge branch 'develop' of github.com:palantir/blueprint into gg/more-iconsPreview: documentation | landing | table |
|
more conflicts |
Merge branch 'develop' of github.com:palantir/blueprint into gg/more-iconsPreview: documentation | landing | table |
adidahiya
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2028
Use
Iconin almost all the places. The final outstanding usage is inTimePicker, and I have a separate PR for that as it's a larger refactor.This change is unrelated to introducing SVG icons and will simply enable these components to pick up that change for free.