Add vertical padding to "Tag" component for large style #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @Eusbolh! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
previously approved these changes
Apr 29, 2020
| @@ -70,7 +71,7 @@ $tag-round-adjustment: 2px !default; | |||
| line-height: $tag-line-height-large; | |||
| min-height: $tag-height-large; | |||
| min-width: $tag-height-large; | |||
| padding: 0 $tag-padding-large; | |||
| padding: $tag-padding-large-top $tag-padding-large; | |||
There was a problem hiding this comment.
can you just use ($tag-padding-large / 2) here instead? I'd prefer that over adding a new Sass variable
adidahiya
suggested changes
Apr 29, 2020
adidahiya
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4037
Checklist
Changes proposed in this pull request:
Add vertical padding to "Tag" component for large style
Reviewers should focus on:
Ratio between horizontal and vertical padding value should be decided. For default style, the ratio between horizontal and vertical padding is 3 to 2. However, I followed 2 to 1 ratio for large style which is the current ratio for single line large tags.
Screenshot
There is no visual change for single line content.
For multiline content, the old version is:
The updated version for multiline content is: