Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Tag): restore 30px height for removable tags #4414

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[core] fix(Tag): restore 30px height for removable tags #4414

merged 1 commit into from
Nov 12, 2020

Conversation

adidahiya
Copy link
Contributor

Fixes #4397

Regression was introduced by #4099

@blueprint-bot
Copy link

[core] fix(Tag): restore 30px height for removable tags

Previews: documentation | landing | table

invliD
invliD approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@invliD invliD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sweet! I hadn't noticed this only happens for removable tags, but those are indeed what I saw affected.

@adidahiya adidahiya merged commit 8ce75d4 into develop Nov 12, 2020
@adidahiya adidahiya deleted the ad/fix-tag-padding branch November 12, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large tags have unusually large padding
3 participants
@adidahiya @blueprint-bot @invliD