Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-build-scripts] feat: upgrade to node-sass v6 #5211

Merged
merged 14 commits into from
Mar 31, 2022
Merged

[node-build-scripts] feat: upgrade to node-sass v6 #5211

merged 14 commits into from
Mar 31, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Mar 31, 2022 •
edited

Fixes #4415

Changes proposed in this pull request:

  • Migrate from legacy convenience CircleCI images to next-gen convenience images and install browser orb
  • Build with Node v12.22, specified in .nvmrc
  • Upgrade node-sass to v6, fixing Sass compilation failing in Node 14 environment #4415 and related issues (we now can build with an active version of Node.js)
  • Upgrade CSS-related dependencies in node-build-scripts except for stylelint and strip-css-comments
  • Upgrade Lerna to v4.0.0 (see changelog)
  • Upgrade yarn-deduplicate to v4.0.0 (see changelog)
  • Added polyfill for "stream" module in karma webpack config
    • Not totally sure why this is a new requirement... I think the new Chrome browser version doesn't have this module available in the same way as before...?

Reviewers should focus on:

No regressions

Screenshot

N/A

@blueprint-bot
Copy link

[node-build-scripts] feat: upgrade to node-sass v6

Previews: documentation | landing | table | demo

@adidahiya adidahiya mentioned this pull request Mar 31, 2022
Closed
@blueprint-bot
Copy link

Dedupe lockfile

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

upgrade yarn-deduplicate

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

clean lockfile

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit ce34002 into develop Mar 31, 2022
@adidahiya adidahiya deleted the ad/node-sass-6 branch March 31, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Domain: tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sass compilation failing in Node 14 environment
2 participants
@adidahiya @blueprint-bot