Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix: refactor typography colors into mixins #5287

Merged
merged 5 commits into from
May 5, 2022
Merged

[core] fix: refactor typography colors into mixins #5287

merged 5 commits into from
May 5, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented May 4, 2022 •
edited

Fixes #5072

Changes proposed in this pull request:

  • Refactor all typography color styles into pt-typography-colors() and pt-dark-typography-colors() mixins
  • Use these mixins in Tooltip and Tooltip2 styles to override the default colors since we use inverted backgrounds

Reviewers should focus on:

No regressions

Screenshot

image

image

@blueprint-bot
Copy link

Add variables-extended file to git :(

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 9a6ba57 into develop May 5, 2022
@adidahiya adidahiya deleted the ad/typography-mixins branch May 5, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Icon> with Intent on a component with dark background (eg. Tooltip2) has too dark colors
2 participants
@adidahiya @blueprint-bot