[core] fix: improve contrast for disabled inputs in iOS #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios fixPreviews: documentation | landing | table | demo |
|
regular text inputs look fine but the text in TagInput tags is now unreadable in iOS:
|
adidahiya
suggested changes
Oct 4, 2022
| @@ -142,6 +142,11 @@ $control-group-stack: ( | |||
| cursor: not-allowed; | |||
| resize: none; | |||
|
|
|||
| @supports (-webkit-touch-callout: none) { | |||
There was a problem hiding this comment.
please add a code comment explaining that this is for iOS support
adidahiya
changed the title
more targeted fixPreviews: documentation | landing | table | demo |
|
Thanks for finding the issue with TagInput! Given iOS renders only disabled
while testing I also noticed we should have an override for dark-mode, so added it as well :)
|
fix for dark modePreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
No additional documentation/tests necessary
Changes proposed in this pull request:
Fix or iOS specific styling, based on:
https://stackoverflow.com/questions/262158/disabled-input-text-color-on-ios
and:
https://stackoverflow.com/questions/30102792/css-media-query-to-target-only-ios-devices
Reviewers should focus on:
Screenshot
Before
After