Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix: improve contrast for disabled inputs in iOS #5641

Merged
merged 4 commits into from
Oct 5, 2022
Merged

[core] fix: improve contrast for disabled inputs in iOS #5641

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f17adf
ios fix
Oct 4, 2022
eb3b4ba
Merge branch 'develop' into md/ios-disabled-state-contrast-fix
Oct 4, 2022
aecd42e
more targeted fix
Oct 4, 2022
91db785
fix for dark mode
Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/core/src/components/forms/_input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,23 @@ Styleguide input
}
}

// for iOS support
@supports (-webkit-touch-callout: none) {
// only html input elements require a fix on iOS
input.#{$ns}-input {
&:disabled,
&.#{$ns}-disabled {
opacity: 1;
-webkit-text-fill-color: $input-color-disabled;

.#{$ns}-dark & {
-webkit-text-fill-color: $dark-input-color-disabled;
}
}
}
}


/*
Search inputs
Expand Down