Fix TagInput adding a tag when Enter is pressed while composing

[jrafidi]

Fixes

The TagInput component has a built-in Enter handler for adding a tag based on the current input value. This key is hit when composing languages such as Korean or Japanese, but not for the reason of adding a tag.

The current implementation will both add a tag of the current value and keep the current value, which is unexpected behavior.

This implementation should ignore Enter keystrokes when the user is in the middle of composing.

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

See above description.

Reviewers should focus on:

Whether or not we need to fix this in other places in Blueprint.

Screenshot

[changelog-app]

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Fix TagInput adding a tag when Enter is pressed while composing

Check the box to generate changelog(s)

• Generate changelog entry

[ericjeney]

Thanks for fixing!

There are a few other places where we fix this today, such as in #4266, but I think that's partially because the isComposing property on the native keyboard event wasn't rolled out broadly at the time.