-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle flex-expander case in tabs gap #6894
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
Add generated changelog entriesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
only verticalBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
// some consumers may have targeted the default margin-right to override it and this | ||
// should wipe out their override and at least reset them to the default gap style | ||
// instead of applying both the gap style and whatever margin-right they have defined | ||
style={{ ...child.props.style, marginRight: 0 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 8734e28.
Revert "prevent user margin-right style"Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
See Tabs docs: https://blueprintjs.com/docs/#core/components/tabs - there's currently 40px between the search input and the last tab, because of a double gap on the flex-expander. This was an existing issue before the change from margin-right -> gap.
This PR adds a style targeting the flex-expander with a negative margin to remove the gap added due to the expander component.