Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to use golang/dep #16

Merged
merged 4 commits into from Oct 2, 2017
Merged

Moving to use golang/dep #16

merged 4 commits into from Oct 2, 2017

Conversation

ungureanuvladvictor
Copy link
Member

Thinking about moving to use golang/dep as dependency manager for bulldozer.

@ajlake
Copy link
Contributor

ajlake commented Oct 1, 2017

I'm not sure where the +2.3 million LOC comes from. Swapping vendor tools should be roughly net zero so where is the discrepancy coming from? How do the built binary sizes compare?

@bluekeyes
Copy link
Member

Did you run dep prune before committing the vendor directory?

@ungureanuvladvictor
Copy link
Member Author

Looks like that brought down the LOC count.

@ungureanuvladvictor ungureanuvladvictor merged commit ed7b103 into master Oct 2, 2017
@ungureanuvladvictor ungureanuvladvictor deleted the feat/dep branch October 2, 2017 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlake ajlake ajlake approved these changes

@bluekeyes bluekeyes Awaiting requested review from bluekeyes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ungureanuvladvictor @ajlake @bluekeyes