Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to use golang/dep #16

Merged
merged 4 commits into from
Oct 2, 2017
Merged

Moving to use golang/dep #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b57668f
Swap to using golang/dep as dependency manager
ungureanuvladvictor Sep 30, 2017
15b32e5
Pin packages to specific revisions
ungureanuvladvictor Sep 30, 2017
605c11b
Use reviewers.Users (go-github upgrade)
ungureanuvladvictor Sep 30, 2017
6234886
Run dep prune
ungureanuvladvictor Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
285 changes: 285 additions & 0 deletions Gopkg.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

74 changes: 74 additions & 0 deletions Gopkg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@

# Gopkg.toml example
#
# Refer to https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md
# for detailed Gopkg.toml documentation.
#
# required = ["github.com/user/thing/cmd/thing"]
# ignored = ["github.com/user/project/pkgX", "bitbucket.org/user/project/pkgA/pkgY"]
#
# [[constraint]]
# name = "github.com/user/project"
# version = "1.0.0"
#
# [[constraint]]
# name = "github.com/user/project2"
# branch = "dev"
# source = "github.com/myfork/project2"
#
# [[override]]
# name = "github.com/x/y"
# version = "2.4.0"


[[constraint]]
name = "github.com/google/go-github"
revision = "511f540f1887d30b88cee4a2fcd1f2922754acf4"

[[constraint]]
name = "github.com/ipfans/echo-session"
version = "3.1.1"

[[constraint]]
name = "github.com/jmoiron/sqlx"
revision = "d9bd385d68c068f1fabb5057e3dedcbcbb039d0f"

[[constraint]]
name = "github.com/labstack/echo"
version = "3.2.3"

[[constraint]]
name = "github.com/lib/pq"
revision = "b77235e3890a962fe8a6f8c4c7198679ca7814e7"

[[constraint]]
name = "github.com/pkg/errors"
version = "0.8.0"

[[constraint]]
name = "github.com/sirupsen/logrus"
version = "1.0.3"

[[constraint]]
name = "github.com/spf13/cobra"
revision = "e5f66de850af3302fbe378c8acded2b0fa55472c"

[[constraint]]
name = "github.com/spf13/viper"
version = "1.0.0"

[[constraint]]
name = "github.com/stretchr/testify"
version = "1.1.4"

[[constraint]]
name = "golang.org/x/oauth2"
revision = "bb50c06baba3d0c76f9d125c0719093e315b5b44"

[[constraint]]
name = "gopkg.in/go-playground/validator.v9"
version = "9.7.0"

[[constraint]]
name = "gopkg.in/yaml.v2"
revision = "eb3733d160e74a9c7e442f435eb3bea458e1d19f"
6 changes: 3 additions & 3 deletions github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func (client *Client) ReviewStatus(pr *github.PullRequest) (bool, error) {
}
reviewRequired := protection.RequiredPullRequestReviews != nil

if len(reviewers) == 0 && len(reviews) == 0 && !reviewRequired {
if len(reviewers.Users) == 0 && len(reviews) == 0 && !reviewRequired {
logger.WithFields(logrus.Fields{
"repo": repo.GetFullName(),
"pr": pr.GetNumber(),
Expand All @@ -469,7 +469,7 @@ func (client *Client) ReviewStatus(pr *github.PullRequest) (bool, error) {
logger.WithFields(logrus.Fields{
"repo": repo.GetFullName(),
"pr": pr.GetNumber(),
"nReviewers": len(reviewers),
"nReviewers": len(reviewers.Users),
"nReviews": len(reviews),
}).Info("Pull request has reviewers/reviews")
logger.WithFields(logrus.Fields{
Expand All @@ -484,7 +484,7 @@ func (client *Client) ReviewStatus(pr *github.PullRequest) (bool, error) {
"branch": pr.Base.GetRef(),
}).Debug("Branch requires code reviews")
return approval, nil
} else if len(reviews) != 0 || len(reviewers) != 0 {
} else if len(reviews) != 0 || len(reviewers.Users) != 0 {
return approval, nil
}

Expand Down