-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support required statuses for Bulldozer to update PRs #307
Merged
bluekeyes
merged 15 commits into
palantir:develop
from
wrslatz:required-statuses-update
May 20, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
56f3d36
Add required statuses to update config
wrslatz 4107c64
Move ShouldUpdatePR to evaluate to match ShouldMergePR for reuse
wrslatz 3e2fbb5
Improve config tests for new and default values
wrslatz b1e3c54
Implement required statuses for update
wrslatz f6de650
Make logs for should update vs merge more distinct
wrslatz 335d27e
Fix update ignored when required statuses set
wrslatz 7d9ea83
Document required statuses config for updates
wrslatz 3e9e118
Handle updates on check run and status events
wrslatz 579e995
Refactor update test cases to table format
wrslatz f66e987
Finish update test refactor, add required statuses tests
wrslatz bb557b8
More required status test cases
wrslatz 0e1a092
Document required statuses and explicit trigger for updates
wrslatz 75c6e43
Remove TODO in TestShouldUpdatePR for error tests
wrslatz 92aad8f
Simplify handling updates for check and status events
wrslatz 96baa96
Refactor TestShouldUpdatePR cases to map
wrslatz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying/deduplicating these messages!