conjure assertions provide diagnostic info for unexpected exceptions #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the idea provided by #882, implemented to use standard assertj types and provide feedback consistent with builtin assertj checks.
Generate changelog in
|
carterkozak
commented
Aug 8, 2022
| @@ -73,7 +73,7 @@ private void failIfNotEqual(String message, Object expected, Object actual) { | |||
| public final ServiceExceptionAssert containsArgs(Arg<?>... args) { | |||
| isNotNull(); | |||
|
|
|||
| AssertableArgs actualArgs = new AssertableArgs(actual.getParameters()); | |||
| AssertableArgs actualArgs = new AssertableArgs(actual.getArgs()); | |||
There was a problem hiding this comment.
Migrated away from deprecated methods
carterkozak
commented
Aug 8, 2022
| .hasMessage("Expecting code to throw a com.palantir.conjure.java.api.errors.ServiceException," | ||
| + " but caught a java.lang.RuntimeException."); | ||
| .hasMessageContaining( | ||
| "com.palantir.conjure.java.api.errors.ServiceException", "java.lang.RuntimeException"); |
There was a problem hiding this comment.
Generified the asserts since it's not generally helpful to test precise string matches.
There was a problem hiding this comment.
I don't care about the precise string, but maybe to test that we are serializing the underlying error messages:
assertThatThrownBy(() -> assertThatServiceExceptionThrownBy(() -> {
throw new RuntimeException("My helpful message");
}))
.hasMessageContaining(
"com.palantir.conjure.java.api.errors.ServiceException",
"java.lang.RuntimeException",
"My helpful message");
jkozlowski
approved these changes
Aug 9, 2022
|
Released 2.28.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the idea provided by #882, implemented to use
standard assertj types and provide feedback consistent with builtin
assertj checks.
==COMMIT_MSG==
conjure assertions provide diagnostic info for unexpected exceptions
==COMMIT_MSG==