Excavator: Upgrades Baseline to the latest version #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
2 times, most recently
from
210b289
to
ec81568
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
6 times, most recently
from
97bf55a
to
4ebe12c
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
4ebe12c
to
3626528
Compare
| private static final Logger log = LoggerFactory.getLogger(AutoDeserializeTest.class); | ||
| static { | ||
| LoggerFactory.getLogger(AutoDeserializeTest.class); | ||
| } |
There was a problem hiding this comment.
we should have an exception to the keep-side-effects rule that allows removing loggers completely
dansanduleac
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.8.0
2.8.1
2.9.0
_prefixbaselineErrorProne { patchChecks += 'PreferAssertj' }2.9.1
StrictUnusedVariablecorrectly converts previously suppressed variablesunusedto_2.9.2
StrictUnusedVariablewill preserve side effects2.10.0
checkJUnitDependenciestask detects misconfigured JUnit dependencies which could result in some tests silently not running.2.10.1
2.11.0
2.11.1
2.11.2
assertThatimports2.12.0
UnusedVariableerror prone rule by default2.13.0
@TestTemplateannotation is now used to detect whether a class is test code.2.14.0
2.15.0
No documented user facing changes
2.16.0
isEqualTochecks intohasValuechecks2.17.0
2.18.0
2.19.0
2.20.0
UnnecessaryParenthesesby defaultThrowErrorto discourage throwing Errors in production codeErrors are often handled poorly by libraries resulting in unexpected
behavior and resource leaks. It's not obvious that 'catch (Exception e)'
does not catch Error.
This check is intended to be advisory - it's fine to
@SuppressWarnings("ThrowError")in certain cases, but is usually notrecommended unless you are writing a testing library that throws
AssertionError.
Slf4jLevelCheckto validate that slf4j level checks agree with contained logging.2.20.1
2.21.0
2.22.0
Automated release, no documented user facing changes
2.23.0
Calling address.getHostName may result in a DNS lookup which is a network request,
making the invocation significantly more expensive than expected depending on the
environment.
This check is intended to be advisory - it's fine to
@SuppressWarnings("ReverseDnsLookup") in certain cases, but is usually not
recommended.
2.24.0
verifyZeroInteractionsnow gets rewritten toverifyNoMoreInteractions, which has the same behaviour.com.palantir.safe-logging:preconditions).2.25.0
com.palantir-java-formatwhich is also used to determine the version used by IntelliJ.To enable or disable this check, please contact the maintainers of Excavator.