Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode errors during deserialization #113

Merged
merged 4 commits into from
May 29, 2019
Merged

Decode errors during deserialization #113

merged 4 commits into from
May 29, 2019

Conversation

ellisjoe
Copy link
Contributor

No description provided.

@ellisjoe ellisjoe requested a review from uschi2000 May 29, 2019 15:14
@@ -50,8 +53,15 @@
* by a given request, or the first serializer if no such serializer can be found.
*/
ConjureBodySerDe(List<Encoding> encodings) {
// TODO(jellis): consider supporting cbor encoded errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course

@Test
public void testErrorsDecoded() {
TestResponse response = new TestResponse();
// response.contentType();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

@ellisjoe ellisjoe merged commit b0f7900 into develop May 29, 2019
@ellisjoe ellisjoe deleted the jellis/decodeErrors branch May 29, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants