Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin until error strategy attempts to find an active channel #445

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

carterkozak
Copy link
Contributor

PinUntilErrorChannel behavior matches round robin more closely
when many channels are blacklisted. Clients are no longer forced
to use N retries to find the next available channel.

==COMMIT_MSG==
Pin until error strategy attempts to find an active channel rather than bailing on the first limited channel. This matches round robin more closely when many channels are blacklisted. Clients are no longer forced to use N retries to find the next available channel.
==COMMIT_MSG==

PinUntilErrorChannel behavior matches round robin more closely
when many channels are blacklisted. Clients are no longer forced
to use N retries to find the next available channel.
@changelog-app
Copy link

changelog-app bot commented Feb 27, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Pin until error strategy attempts to find an active channel rather than bailing on the first limited channel. This matches round robin more closely when many channels are blacklisted. Clients are no longer forced to use N retries to find the next available channel.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep makes sense. No need to burn retries hopping slowly through a list of blacklisted channels before we get to one that's ready!

@bulldozer-bot bulldozer-bot bot merged commit ea75066 into develop Feb 27, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/pin_until_error branch February 27, 2020 01:50
@svc-autorelease
Copy link
Collaborator

Released 0.10.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants