Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork DeterministicScheduler to support nanoseconds #459

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

carterkozak
Copy link
Contributor

This prevents us from attempting to go back in time. Without allowing
small time-slip we can build confidence that new functionality doesn't
cause us to regress.

Fork will be unnecessary if the upstream fix is accepted:
jmock-developers/jmock-library#172
jmock-developers/jmock-library#173

==COMMIT_MSG==
Fork DeterministicScheduler to support nanoseconds
==COMMIT_MSG==

TimeUnit.MICROSECONDS.convert(difference, TimeUnit.NANOSECONDS));
return;
throw new SafeIllegalStateException(
"Time rewind - this is likely a bug in the test harness", SafeArg.of("difference", difference));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more wiggle room.

This prevents us from attempting to go back in time. Without allowing
small time-slip we can build confidence that new functionality doesn't
cause us to regress.

Fork will be unnecessary if the upstream fix is accepted:
jmock-developers/jmock-library#172
jmock-developers/jmock-library#173
@bulldozer-bot bulldozer-bot bot merged commit 3e99df1 into develop Mar 2, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/custom_scheduler branch March 2, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants