-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some logic from generated code into the runtime library #475
Changes from 1 commit
768b98c
eb9c8f1
351e28c
7c11415
7f3bd22
4b82096
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* (c) Copyright 2020 Palantir Technologies Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.palantir.conjure.java.dialogue.serde; | ||
|
||
import com.google.common.util.concurrent.Futures; | ||
import com.google.common.util.concurrent.ListenableFuture; | ||
import com.google.common.util.concurrent.MoreExecutors; | ||
import com.palantir.dialogue.Channel; | ||
import com.palantir.dialogue.Clients; | ||
import com.palantir.dialogue.Deserializer; | ||
import com.palantir.dialogue.Endpoint; | ||
import com.palantir.dialogue.RemoteExceptions; | ||
import com.palantir.dialogue.Request; | ||
|
||
enum DefaultClients implements Clients { | ||
INSTANCE; | ||
|
||
@Override | ||
public <T> ListenableFuture<T> call( | ||
Channel channel, Endpoint endpoint, Request request, Deserializer<T> deserializer) { | ||
return Futures.transform( | ||
channel.execute(endpoint, request), deserializer::deserialize, MoreExecutors.directExecutor()); | ||
} | ||
|
||
@Override | ||
public <T> T blocking(Channel channel, Endpoint endpoint, Request request, Deserializer<T> deserializer) { | ||
ListenableFuture<T> call = call(channel, endpoint, request, deserializer); | ||
return RemoteExceptions.getUnchecked(call); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure lets do it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll plan to move this after we've cut a release where generated code uses the new methods, that way we have a window for libraries to safely upgrade. |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
import com.google.common.collect.ImmutableList; | ||
import com.google.errorprone.annotations.CanIgnoreReturnValue; | ||
import com.palantir.dialogue.BodySerDe; | ||
import com.palantir.dialogue.Clients; | ||
import com.palantir.dialogue.ConjureRuntime; | ||
import com.palantir.dialogue.PlainSerDe; | ||
import com.palantir.logsafe.Preconditions; | ||
|
@@ -52,6 +53,11 @@ public PlainSerDe plainSerDe() { | |
return ConjurePlainSerDe.INSTANCE; | ||
} | ||
|
||
@Override | ||
public Clients clients() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thoughts on naming? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like it! |
||
return DefaultClients.INSTANCE; | ||
} | ||
|
||
public static final class Builder { | ||
|
||
private final List<Encoding> encodings = new ArrayList<>(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* (c) Copyright 2020 Palantir Technologies Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.palantir.dialogue; | ||
|
||
import com.google.common.util.concurrent.ListenableFuture; | ||
|
||
public interface Clients { | ||
|
||
<T> ListenableFuture<T> call(Channel channel, Endpoint endpoint, Request request, Deserializer<T> deserializer); | ||
|
||
<T> T blocking(Channel channel, Endpoint endpoint, Request request, Deserializer<T> deserializer); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this interface doesn't quite work with the existing codegen. It would force us to duplicate the code for building the request in the blocking/async impls There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah doh, our sample services are no longer representative There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could go either way naming There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think i prefer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 thanks! |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the serde package+module don't make a great deal of sense for the entire runtime object, but I'm not going to couple changing that with this PR.