Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Typescript v2.0 #331

Closed
nchen63 opened this issue Sep 2, 2016 · 14 comments
Closed

Support Typescript v2.0 #331

nchen63 opened this issue Sep 2, 2016 · 14 comments

Comments

@nchen63
Copy link

nchen63 commented Sep 2, 2016

No description provided.

@caugner
Copy link

caugner commented Sep 27, 2016

@derekcicerone Any ideas what needs to be done in order to support TypeScript 2.0?

@derekcicerone-zz
Copy link
Contributor

Sorry, I'm not a maintainer on this project any longer. Perhaps the current maintainers could chime in...

@adidahiya
Copy link

tsconfig.json support is here: #323

@nchen63 have you been able to run this plugin with TS 2.0? if not, what errors does it produce?

@david-bouyssie
Copy link

👍

@nchen63
Copy link
Author

nchen63 commented Oct 16, 2016

@adidahiya: did not realize that tsconfig was supported. haven't tried it yet

lgrignon referenced this issue Jan 9, 2017
* tsconfig file could be read if requested, and applied to parameters

* fixed project recompile

* moved prompt recompilation

* prompts to recompile on use tsconfig check

* force reload button + added more efficient enum values mapping

* fixed error on maven compile + fixed checkstyle warning

* added emitDecoratorMetadata option

* tsconfig "files" works with file and directories

* fixed exclude list + reset tsconfig preferences on reload to avoid files/include/exclude persistence

* disabled source folder field if tsconfig enabled

* take palantir's feedbacks in account + fix some bugs

* * fixed empty sources set bug * fixed compileOnSave blocking problem * fixed languageEndPoint missing ref

* fixed pref store
@lgrignon
Copy link
Contributor

lgrignon commented Jan 9, 2017

As requested by @sixinli, we should support globs in tsconfig.json as well.

@sixinli
Copy link
Collaborator

sixinli commented Jan 11, 2017

closing this with #339, add #342 to track glob support

@sixinli sixinli closed this as completed Jan 11, 2017
@david-bouyssie
Copy link

Nice work !

Any plan to release it on http://eclipse-update.palantir.com/ ?

@sixinli
Copy link
Collaborator

sixinli commented Jan 18, 2017

@david-bouyssie thanks for checking, we are still figuring out new way of updating the site, for now you might need to build the package locally for use

@david-bouyssie
Copy link

I tried to build and install the plugin.
I have now a successful build.
However I'm not able to install it in Eclipse.
I have the following error message:

Cannot complete the request. See the error log for details.
TypeScript will be ignored because it is already installed, and updates are not permitted.

@Rouche
Copy link
Contributor

Rouche commented Jan 19, 2017

Uninstall it first, (Help->Iinstallation Details) and remove the com.palantir.typescript._xxxx directory manually in \plugins.
restart eclipse with -clean.

@david-bouyssie
Copy link

Did it. Installation is ok now.

However I'm stuck at the running time now.
If I try to open a TS file I have the following error.

Failed to create the part's controls

java.lang.IllegalStateException: The node process has crashed.
	at com.palantir.typescript.services.Bridge.processRequest(Bridge.java:133)
	at com.palantir.typescript.services.Bridge.call(Bridge.java:95)
	at com.palantir.typescript.services.classifier.Classifier.getClassificationsForLines(Classifier.java:50)
	at com.palantir.typescript.text.reconciler.PresentationReconciler.classifyLines(PresentationReconciler.java:252)
	at com.palantir.typescript.text.reconciler.PresentationReconciler.createPresentation(PresentationReconciler.java:222)
	at com.palantir.typescript.text.reconciler.PresentationReconciler.processEvent(PresentationReconciler.java:123)
	at com.palantir.typescript.text.reconciler.PresentationReconciler.access$0(PresentationReconciler.java:119)
	at com.palantir.typescript.text.reconciler.PresentationReconciler$MyTextListener.textChanged(PresentationReconciler.java:310)
	at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2826)
	at org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:3478)
	at org.eclipse.jface.text.TextViewer.initializeWidgetContents(TextViewer.java:3525)
	at org.eclipse.jface.text.TextViewer.setVisibleDocument(TextViewer.java:3564)
	at org.eclipse.jface.text.TextViewer.setDocument(TextViewer.java:2934)
	at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java:643)
	at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java:591)
	at org.eclipse.ui.texteditor.AbstractTextEditor.initializeSourceViewer(AbstractTextEditor.java:4050)

I tried to upgrade NodeJS to the latest available version and the problem is still there.

@Rouche
Copy link
Contributor

Rouche commented Jan 19, 2017

#237

Follow instruction in wiki/readme.md how to build, very carefully.
Need to do it perfect clean and of course you have to go get TypeScript sources from github.

@david-bouyssie
Copy link

I downloaded the latest version of this repo and just did a "mvn package" on it.
I think I will wait for an a pre-built version.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants