Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ts to 2.1 #339

Merged
merged 5 commits into from
Jan 9, 2017
Merged

Bump ts to 2.1 #339

merged 5 commits into from
Jan 9, 2017

Conversation

sixinli
Copy link
Collaborator

@sixinli sixinli commented Jan 7, 2017

fixed a few more things after #337

@Rouche @mzmaryzhuang

@Rouche
Copy link
Contributor

Rouche commented Jan 7, 2017

Cool @sixinli
Did you merged my fork? If no, this commit end up almost identical lol.

I had a few more fixes, #337 changed the updateTypeScript.sh case of directory, i did the same because the directory in the first line (cd ..\TypeScript) is cased.

For the doc, dont you need -g option? npm install -g dos2unix jake

I also wanted to bump Tycko to latest version (0.26) so the reference in the project can be JavaSE_1.8.

And of course double verify compiler options.

@sixinli
Copy link
Collaborator Author

sixinli commented Jan 7, 2017

ah cool, I ended up making the same change while trying to get it to build locally :)

I can update the Typescript casing, do you mind opening a separate PR for updating Tycko @Rouche ? I will update the docs PR too

@sixinli sixinli changed the title Bump ts to 2 1 Bump ts to 2.1 Jan 7, 2017
@Rouche
Copy link
Contributor

Rouche commented Jan 9, 2017

This also fixes #331 #328

@Rouche
Copy link
Contributor

Rouche commented Jan 9, 2017

@sixinli Hi, did you get my mail about the casing? (TypeScript) is the name of the Git repository by default. (https://github.com/Microsoft/TypeScript) for the commandline to work,

Also, I just updated Tycho to 0.26.0 and changed the Eclipse repository to use Mars instead of Kepler.

Problem is it will have conflicts with your commit. I will have to wait for yours to be merged because i need to remove .qualifier from versions in pom.xml due to changes in Tycho validations.

Its in my fork.

@sixinli
Copy link
Collaborator Author

sixinli commented Jan 9, 2017

oops my bad on misreading the casing, changing it now

@sixinli
Copy link
Collaborator Author

sixinli commented Jan 9, 2017

@Rouche looks good? will merge if so :)

@Rouche
Copy link
Contributor

Rouche commented Jan 9, 2017

@sixinli Yep! 👍

@sixinli sixinli merged commit 62f422e into master Jan 9, 2017
@sixinli
Copy link
Collaborator Author

sixinli commented Jan 9, 2017

@Rouche the publish task has some problem, we are fixing it atm. You might need to build it locally for now :( sorry

@sixinli sixinli deleted the bump_ts_to_2_1 branch January 9, 2017 20:38
@Rouche
Copy link
Contributor

Rouche commented Jan 9, 2017

Yeah no problem.

Will re-fork and PR the Tycho update later this week.

@sixinli sixinli mentioned this pull request Jan 11, 2017
@david-bouyssie
Copy link

david-bouyssie commented Jan 18, 2017

BUILD SUCCESS only if I use the following command line:
mvn -DforceContextQualifier=true package

Otherwise I get the error:
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.18.1:build-qualifier (default-build-qualifier) on project com.palantir.typescript: Execution default-build-qualifier of goal org.eclipse.tycho:tycho-packaging-plugin:0.18.1:build-qualifier failed: One of setGitDir or setWorkTree must be called.

@Rouche
Copy link
Contributor

Rouche commented Jan 18, 2017

Maven version maybe? Runnin in parent dir? Option in settings.xml? Just ideas, hard to tell when travis build is ok and mine too.

@david-bouyssie
Copy link

My maven version is 3.3.3
However my "settings.xml" file is configured to target an artifactory, so it may explain the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants