Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer panic when using default transport #105

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Fix nil pointer panic when using default transport #105

merged 1 commit into from
Sep 12, 2021

Conversation

bluekeyes
Copy link
Member

This was a regression introduced by the WithTransport option. Fixes #104.

@bluekeyes
Fix nil pointer panic when using default transport
5ab844c 
This was a regression introduced by the WithTransport option.
@bluekeyes bluekeyes requested a review from a team September 11, 2021 20:41
@bluekeyes bluekeyes mentioned this pull request Sep 11, 2021
Closed
davidkarlsen
davidkarlsen approved these changes Sep 11, 2021
View reviewed changes
Copy link

@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bluekeyes bluekeyes merged commit 1e07c75 into develop Sep 12, 2021
@bluekeyes bluekeyes deleted the bkeyes/fix-nil-transport branch September 12, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@asvoboda asvoboda asvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't use app authentication with v4 client
3 participants
@bluekeyes @davidkarlsen @asvoboda