-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
a3494b5
commit 201be35
Showing
1 changed file
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
type: improvement | ||
improvement: | ||
description: |- | ||
Implement Error Prone `ThrowError` to discourage throwing Errors in production code | ||
Errors are often handled poorly by libraries resulting in unexpected | ||
behavior and resource leaks. It's not obvious that 'catch (Exception e)' | ||
does not catch Error. | ||
This check is intended to be advisory - it's fine to | ||
`@SuppressWarnings("ThrowError")` in certain cases, but is usually not | ||
recommended unless you are writing a testing library that throws | ||
AssertionError. | ||
links: | ||
- https://github.com/palantir/gradle-baseline/pull/957 |