Disable FallThrough on Java 14 for switch expressions #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
commented
Jun 30, 2020
| " };", | ||
| " }", | ||
| "}") | ||
| .expectErrorMessage("X", input -> input.contains("Execution may fall through from the previous case")) |
There was a problem hiding this comment.
I had to use Diagnostic matches and expectErrorMessage because otherwise the diagnostic message matches the magic comment that will suppress the check.
https://github.com/google/error-prone/blob/v2.4.0/core/src/main/java/com/google/errorprone/bugpatterns/FallThrough.java#L45-L46
iamdanfox
approved these changes
Jul 1, 2020
|
👍 |
|
Released 3.33.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1413
Before this PR
There is a false negative with
FallThroughon Java 14 when using switch expressions where the case arms are statements (as opposed to expressions).See google/error-prone#1649.
After this PR
Disable
FallThroughon Java 14.