Fix baseline-exact-dependencies with new GCV #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Is it possible to write a test for this? Does it work with GCV <1.26.0 too? |
|
We're currently testing it with old GCV - I suppose I could add a test for new GCV but the problem is the issue we've seen is a heisenbug... I couldn't reproduce it locally, for instance. |
CRogers
reviewed
Sep 2, 2020
| // Alternatively, we could tell GCV to lock this configuration, at the cost of a slightly more | ||
| // expensive 'unifiedClasspath' resolution during lock computation. | ||
| if (project.getRootProject().getPluginManager().hasPlugin("com.palantir.versions-lock")) { | ||
| explicitCompile.extendsFrom(project.getConfigurations().getByName("lockConstraints")); |
There was a problem hiding this comment.
Feels quite weird to have this direct knowledge of GCV here? Will this still work with old GCV?
|
I am also struggling to reproduce this bug locally anywhere :( |
|
👍 Let's see if this fixes people's problems |
|
Released 3.37.1 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
com.palantir.baseline-exact-dependenciestries to copy over constraints from<source-set>CompileClasspath, in order to pick up versions.lock constraints generated by GCV.However, after palantir/gradle-consistent-versions#557, these are no longer implemented as explicit constraints inherited by that configuration (which would have shown up in
compileClasspath.getAllDependencyConstraints()), but instead GCV uses a dependency to a configuration on the root project, which itself holds these constraints in a single centralized place.This means that the configuration resolved by tasks like
checkUnusedDependenciesMainetc now lacksversions.lockconstraints, leading to weird outcomes including flakes.After this PR
==COMMIT_MSG==
Fix
com.palantir.baseline-exact-dependenciesto work with GCV 1.26.0+.==COMMIT_MSG==
Possible downsides?