AutoCloseableMustBeClosed doesn't match method overrides #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
In most cases interactions occur with the base interface, not the implementation, so we shouldn't flag implementations of types we cannot control.
carterkozak
force-pushed
the
ckozak/AutoCloseableMustBeClosed_ignore_override
branch
from
56e57dd
to
1a86657
Compare
bulldozer-bot
bot
deleted the
ckozak/AutoCloseableMustBeClosed_ignore_override
branch
|
Released 3.74.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases interactions occur with the base interface, not
the implementation, so we shouldn't flag implementations of
types we cannot control.
Before this PR
Lots of findings when the check is enabled.
After this PR
==COMMIT_MSG==
AutoCloseableMustBeClosed doesn't match method overrides
==COMMIT_MSG==
Possible downsides?
Might miss some resource leaks, however I expect it to substantially improve the snr for rollout.