Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug logs for ./gradlew printVersion #717

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add debug logs for ./gradlew printVersion #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae85e37
Add debug logs for ./gradlew printVersion
ash211 Jun 2, 2023
ffa6290
Add generated changelog entries
svc-changelog Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-717.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Add debug logs for ./gradlew printVersion
links:
- https://github.com/palantir/gradle-git-version/pull/717
5 changes: 4 additions & 1 deletion src/main/java/com/palantir/gradle/gitversion/Git.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ private String runGitCmd(Map<String, String> envvars, String... commands) throws
List<String> cmdInput = new ArrayList<>();
cmdInput.add("git");
cmdInput.addAll(Arrays.asList(commands));
log.debug("Running command: {}", cmdInput);
ProcessBuilder pb = new ProcessBuilder(cmdInput);
Map<String, String> environment = pb.environment();
environment.putAll(envvars);
Expand All @@ -80,7 +81,9 @@ private String runGitCmd(Map<String, String> envvars, String... commands) throws
return "";
}

return builder.toString().trim();
String ret = builder.toString().trim();
log.debug("Command returned value: {}", ret);
return ret;
}

public String runGitCommand(Map<String, String> envvar, String... command) {
Expand Down
8 changes: 7 additions & 1 deletion src/main/java/com/palantir/gradle/gitversion/GitVersionPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@
import org.gradle.api.Project;
import org.gradle.api.Task;
import org.gradle.api.provider.Provider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public final class GitVersionPlugin implements Plugin<Project> {

private static final Logger log = LoggerFactory.getLogger(GitVersionPlugin.class);

@Override
public void apply(final Project project) {
project.getRootProject().getPluginManager().apply(GitVersionRootPlugin.class);
Expand All @@ -50,7 +54,9 @@ public VersionDetails doCall(Object args) {
@Override
@SuppressWarnings("BanSystemOut")
public void execute(Task _task) {
System.out.println(project.getVersion());
Object version = project.getVersion();
log.debug("Determined version for project {} is {}", project.getName(), version);
System.out.println(version);
}
});
printVersionTask.setGroup("Versioning");
Expand Down