Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8: Use dynamic proxy for JavaInstallationMetadata #240

Merged
merged 9 commits into from
Oct 18, 2023

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Oct 17, 2023

Before this PR

When used on Gradle 8, running compileJava or related java tasks leads to an error:

Execution failed for task ':<project>:compileJava'.
> Receiver class com.palantir.gradle.jdks.ImmutableGradleJdksJavaInstallationMetadata does not define or inherit an implementation of the resolved method 'abstract boolean isCurrentJvm()' of interface org.gradle.jvm.toolchain.JavaInstallationMetadata.

This is because Gradle have added a method to JavaInstallationMetadata with no default, probably not expecting people to implement it :(.

After this PR

==COMMIT_MSG==
Support Gradle 8, avoid errors of the form "ImmutableGradleJdksJavaInstallationMetadata does not define or inherit an implementation of the resolved method 'abstract boolean isCurrentJvm()'"
==COMMIT_MSG==

Do this by making a dynamic proxy, which should work provided nothing actually calls these extra methods.

Related fix in baseline: palantir/gradle-baseline#2605

Possible downsides?

Wonderful hackery.

@changelog-app
Copy link

changelog-app bot commented Oct 17, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Support Gradle 8, avoid errors of the form "ImmutableGradleJdksJavaInstallationMetadata does not define or inherit an implementation of the resolved method 'abstract boolean isCurrentJvm()'"

Check the box to generate changelog(s)

  • Generate changelog entry

@felixdesouza
Copy link

I'm not sure I understand, why do we have to reimplement this? Didn't we do this in palantir/gradle-baseline#2605 ?

@felixdesouza
Copy link

sorry, accidentally closed

@CRogers
Copy link
Contributor Author

CRogers commented Oct 17, 2023

We implement JavaInstallationMetadata in this repo too, so have the wrong incorrect inferface issue too.

@felixdesouza
Copy link

👍

@bulldozer-bot bulldozer-bot bot merged commit 8345b0e into develop Oct 18, 2023
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/proxy-for-gradle-installation-metadata branch October 18, 2023 12:08
@svc-autorelease
Copy link
Collaborator

Released 0.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants