Refactor create-app dotfile generation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
zeyadkhaled
approved these changes
Feb 5, 2024
| osdkPackage: string; | ||
| osdkRegistryUrl: string; | ||
| }): string { | ||
| const withoutProtocol = osdkRegistryUrl.replace(/^https:\/\//, ""); |
There was a problem hiding this comment.
I guess this is safe given promptOsdkRegistryUrl already tests it against a regex. If we plan to use this somewhere that isn't part of this code path, should we consider passing the protocol but have it with a default value?
There was a problem hiding this comment.
I think the only other protocol that would be relevant would be http but should be safe to only allow https for this url
ericanderson
added a commit
that referenced
this pull request
Feb 13, 2024
* origin/main: Autorelease Increase CLI max width to 150 columns (#47) Debug log site zip stats (#49) Clean up yargs and consola imports (#51) Autorelease Add generated changelog entries Breaking: force dollar sign in osdk verbs for where Display errors more consistently in @osdk/cli (#41) Fix tagPrefix Add generated changelog entries Create foundry.config.json in create-app [3/] Improvement: Use loadedToken for fetching data (#17) Move argv override logging to middleware (#42) Make sure to run all tests (#39) Update create-app to use FOUNDRY_TOKEN in templates (#40) Add generated changelog entries Fix intellisense for aggregations and fill in more number types [2/] Improvement: Introduce new command structure (#16) Autorelease Refactor create-app prompts with tests (#32) Refactor create-app dotfile generation (#31) add changelog Add generated changelog entries Add generated changelog entries put mkdir in right place remove generated files add ignore for legacy client remove deleted file added add back mkdir move mkdir fix fixes keep trying remove module shared testing infra for legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateContexttype to make it clearer what variables are available during templatingThe .npmrc / .env files are shared across all templates but could technically be in the individual template folders. For now I've kept the structure the same as before