Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling ::methodReference #164

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Conversation

dansanduleac
Copy link
Contributor

Before this PR

We could end up with method reference invocations being split onto their own line which looks weird.

After this PR

==COMMIT_MSG==
Method references are no longer split onto their own line unless the expression they're referencing is also completely split.

Fixes #130
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jan 31, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Method references are no longer split onto their own line unless the expression they're referencing is also completely split.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers January 31, 2020 17:07
@bulldozer-bot bulldozer-bot bot merged commit 007dd52 into develop Jan 31, 2020
@bulldozer-bot bulldozer-bot bot deleted the ds/fix-newline-method-ref branch January 31, 2020 17:43
@svc-autorelease
Copy link
Collaborator

Released 0.3.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks on method reference instead of method call
3 participants