Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List our IntelliJ compatibility correctly #874

Merged
merged 2 commits into from
May 22, 2023

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 22, 2023

Before this PR

As per support email reply from Jetbrains, our 2.30.0 release is not being approved as it is incompatible with builds lower than 193. We can fix this temporarily by changing it through the UI, or we can fix it forever by modifying the plugin.xml included with the plugin.

After this PR

==COMMIT_MSG==
Update intellij compatibility range in IntelliJ plugin plugin.xml metadata file.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from fawind May 22, 2023 16:23
@changelog-app
Copy link

changelog-app bot commented May 22, 2023

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Update intellij compatibility range in IntelliJ plugin plugin.xml metadata file.

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -9,6 +9,7 @@
See https://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/plugin_compatibility.html#modules-specific-to-functionality
-->
<depends>com.intellij.modules.java</depends>
<idea-version since-build="193"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my reference: That's the 2019.3 release.

@bulldozer-bot bulldozer-bot bot merged commit 58afdcd into develop May 22, 2023
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/update-compatible-versions branch May 22, 2023 16:27
@svc-autorelease
Copy link
Collaborator

Released 2.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants