Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IntelliJ compatibility bounds correctly #875

Merged
merged 2 commits into from
May 22, 2023

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 22, 2023

Before this PR

In #874, I tried to update the minimum intellij version this is listed to work with. However, it didn't work as the patchPluginXml task changes the plugin.xml file.

After this PR

Use the correct intellij version bound.

==COMMIT_MSG==
Update intellij compatibility range in IntelliJ plugin plugin.xml metadata file, but hopefully correctly this time.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from fawind May 22, 2023 17:28
@changelog-app
Copy link

changelog-app bot commented May 22, 2023

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Update intellij compatibility range in IntelliJ plugin plugin.xml metadata file, but hopefully correctly this time.

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers
Copy link
Contributor Author

CRogers commented May 22, 2023

I ran ./gradlew buildPlugin then checked that the plugin jar contains this in it's plugin.xml:

<idea-version since-build="193" />

by running vim idea-plugin/build/libs/idea-plugin-2.31.0-1-gfdceb49.jar

@bulldozer-bot bulldozer-bot bot merged commit 1ea89cb into develop May 22, 2023
@bulldozer-bot bulldozer-bot bot deleted the callumr/correct-intellij-since-build branch May 22, 2023 18:39
@svc-autorelease
Copy link
Collaborator

Released 2.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants