-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add license header to source files #3206
Conversation
now that we release modules, all source files (that get compiled into the /build folder) should have license headers.
@@ -1,5 +1,5 @@ | |||
/*! | |||
Plottable @VERSION (https://github.com/palantir/plottable) | |||
Copyright 2014-2017 Palantir Technologies | |||
Copyright 2014-present Palantir Technologies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think "present" is an acceptable thing to put here; @themadcreator @adidahiya ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facebook uses this style in their react headers: e.g. https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of wanted:
/**
* Copyright ...
*/
but this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're making changes here, might as well do JSDoc license headers. http://usejsdoc.org/tags-license.html
@adidahiya @themadcreator how's that? |
use jsdoc license headersDemo: quicktests | fiddle |
now that we release modules, all source files (that get compiled into
the /build folder) should have license headers.