Add policy yaml validation endpoint #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Dec 5, 2019
bluekeyes
approved these changes
Dec 10, 2019
README.md
Outdated
| {"message":"failed to parse approval policy: failed to parse subpolicies for 'and': policy references undefined rule 'the devtools team has approved', allowed values: [the devtools team has]","version":"1.12.5"} | ||
| ``` | ||
|
|
||
| You can combine the HTTP response code to automatically detect failures |
There was a problem hiding this comment.
You can examine the HTTP response code to automatically detect failures?
server/handler/validate.go
Outdated
| requestPolicy, err := ioutil.ReadAll(r.Body) | ||
| if err != nil { | ||
| check.Message = "Unable to read policy file buffer" | ||
| baseapp.WriteJSON(w, http.StatusBadRequest, &check) |
There was a problem hiding this comment.
This might be more appropriate as a 500 error? I'm not sure the client did anything wrong here.
|
❤❤❤ |
|
It would be really sweet if I could leave a comment on a PR to ask policy bot to do the validation and post back whether it is valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to resolve #10.
Another approach could also take in the org/repo and current PR to run a more complete validation of all settings, similar to the details endpoint.