Avoid retries for pushedDate loading #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this fallback API was only used for pull requests from forks and we would retry the primary API call for other pull requests. But in practice, we had to retry for up to 15 seconds before success and even then saw occasional failures. Using the fallback method (the commit history API) should be faster and more correct in all cases (the ideal case still being that we get accurate information on the first call.) This also adds a new exit condition to the fallback loop to avoid loading all commits in history under certain error cases.
asvoboda
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this fallback API was only used for pull requests from forks
and we would retry the primary API call for other pull requests. But in
practice, we had to retry for up to 15 seconds before success and even
then saw occasional failures. Using the fallback method (the commit
history API) should be faster and more correct in all cases (the ideal
case still being that we get accurate information on the first call.)
This also adds a new exit condition to the fallback loop to avoid
loading all commits in history under certain error cases.