Convert to modules, upgrade dependencies #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from dep to Go modules and upgrade palantir/go-githubapp, palantir/go-baseapp, and google/go-github. The go-github upgrade required inlining some functions for team operations that were removed due to API changes on GitHub.com. GitHub still supports the old APIs and the new APIs have not shipped in an enterprise release yet.
asvoboda
approved these changes
May 12, 2020
| // TODO(bkeyes): this is a temporary workarount to add functions for APIs that | ||
| // are still supported by GitHub but were removed by google/go-github in | ||
| // v29.0.3. The replacement methods have not shipped in a GitHub Enterprise | ||
| // release yet, so we can't start using them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from dep to Go modules and upgrade palantir/go-githubapp,
palantir/go-baseapp, and google/go-github. The go-github upgrade
required inlining some functions for team operations that were removed
due to API changes on GitHub.com. GitHub still supports the old APIs and
the new APIs have not shipped in an enterprise release yet.