Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the policy file from the detail UI #40

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

bluekeyes
Copy link
Member

@bluekeyes bluekeyes commented Dec 12, 2018

The repository badge in the upper left corner now includes the target
branch name and is a link to the policy file.

Note that this does not resolve references: it always links to the policy.yml in your repository, not the one that defines the actual rules. While resolving references shows the actual policy definition, it may not be obvious that the current repository uses a reference if we link directly to the referenced file.

Here's a preview of the new button:

policy-definition-link

The repository badge in the upper left corner now includes the target
branch name and is a link to the policy file.
Copy link
Member

@jmcampanini jmcampanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

nit: i know that the button is clickable since i read this. i wonder if there's a way to make it more apparent, like an icon, or something? not sure what that would be though

@bluekeyes
Copy link
Member Author

When you hover over it, the text and background change color and the cursor icon switches to a pointer. Do you think that's enough? There's also title text that appears that says "View policy definition on GitHub".

I could also look at changing the colors to be blue or have an underline to make it more link-y.

@jmcampanini
Copy link
Member

pretty sure im just over-optimizing, as is should be good

@asvoboda
Copy link
Member

👍 snazzy

@bluekeyes bluekeyes merged commit 187dac4 into develop Dec 12, 2018
@bluekeyes bluekeyes deleted the bkeyes/policy-link branch December 12, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants