Verify that the pull request head commit exists #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlake
approved these changes
Mar 13, 2019
Some GitHub APIs have a delay propagating information about new commits, particularly when the commits come from forks. While I believe the APIs we currently use are safe, if they are not, the policy should fail closed with an error instead of potentially failing open, as it does currently. Also reorganize some test data so that it is more consistent, making it easier for tests to pass this new check.
bluekeyes
force-pushed
the
bkeyes/check-head-commit
branch
from
a8b94d2
to
39b8d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GitHub APIs have a delay propagating information about new commits, particularly when the commits come from forks. While I believe the APIs we currently use are safe, if they are not, the policy should fail closed with an error instead of potentially failing open, as it does currently.
Also reorganize some test data so that it is more consistent, making it easier for tests to pass this new check.
Fixes #47.