Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the pull request head commit exists #55

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Verify that the pull request head commit exists #55

merged 1 commit into from
Mar 13, 2019

Commits on Mar 13, 2019

  1. Verify that the pull request head commit exists 

    Some GitHub APIs have a delay propagating information about new commits,
particularly when the commits come from forks. While I believe the APIs
we currently use are safe, if they are not, the policy should fail
closed with an error instead of potentially failing open, as it does
currently.

Also reorganize some test data so that it is more consistent, making it
easier for tests to pass this new check.
    @bluekeyes
    bluekeyes committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    39b8d8e View commit details
    Browse the repository at this point in the history