Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server env var prefix to be overridden #610

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

daleal
Copy link
Contributor

@daleal daleal commented Jul 17, 2023

As suggested here, use a POLICYBOT_ENV_PREFIX environment variable to override the prefix for server configuration values. This makes it possible to run the Docker container on Heroku, where it is expected that the container will listen on the port specified in the PORT environment variable. This PR is basically a clone of the same PR for the Bulldozer repo.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/policy-bot, @daleal! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@bluekeyes bluekeyes merged commit ba0024a into palantir:develop Jul 17, 2023
7 checks passed
@daleal
Copy link
Contributor Author

daleal commented Jul 17, 2023

No problem! Just to understand the timeline, when do you think this will make it to your standard Docker image?

@bluekeyes
Copy link
Member

You can try this out using the snapshot tag (palantirtechnologies/policy-bot:snapshot) right now. We'll hopefully tag a proper release within the next week, once we merge some other pending changes.

@daleal
Copy link
Contributor Author

daleal commented Jul 17, 2023

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants