Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add threaded writing #21

Closed

Conversation

HerringtonDarkholme
Copy link

As suggested in #17

Threaded writing will prevent bad client side blocking.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @HerringtonDarkholme! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@guyzmo
Copy link

guyzmo commented May 20, 2017

Hi! Just a thought on this: wouldn't it be better to avoid using threading for that task but rather rely on simpler monothreaded concurrent programming? (using some sort of sugar around select/epoll/kqueue like what asyncio does).

All in all, I just started using the tool and it's ♥

@gatesn
Copy link
Contributor

gatesn commented May 20, 2017

I agree that threaded writing is not the right solution here, given the rest of the server is currently single-threaded it shouldn't be necessary.

I believe the right approach here might be based around a concurrent results queue that each request writes back to with another thread consuming and sending out the results.

@gatesn gatesn closed this May 20, 2017
steff456 pushed a commit to steff456/spyder-pyls that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants