Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple workspaces #601

Merged
merged 16 commits into from Jul 17, 2019

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Jun 18, 2019

This PR enables multi-root support for pyls, thus, enabling a single server to manage multiple workspaces for a single client.

cc @ccordoba12

@andfoy andfoy changed the title PR: Multiple workspace support implementation [WIP] PR: Multiple workspace support implementation Jun 18, 2019
@ccordoba12 ccordoba12 added this to the 0.28.0 milestone Jun 21, 2019
@ccordoba12
Copy link
Contributor

I think the errors in Circle were caused by Jedi 0.14. That should be fixed by PR #607, so please merge with master to get the fix.

@andfoy
Copy link
Contributor Author

andfoy commented Jun 21, 2019

@ccordoba12 I'll add a test, and this one should be ready to merge

@andfoy andfoy changed the title [WIP] PR: Multiple workspace support implementation PR: Multiple workspace support implementation Jun 21, 2019
@andfoy andfoy force-pushed the multiple_workspaces branch 2 times, most recently from 8ce67d9 to 29facdb Compare June 21, 2019 20:36
@andfoy
Copy link
Contributor Author

andfoy commented Jun 21, 2019

@ccordoba12 This one is ready and tested

@ccordoba12
Copy link
Contributor

@andfoy, please solve the merge conflict so I can merge this one. Thanks!

Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy!

@ccordoba12 ccordoba12 changed the title PR: Multiple workspace support implementation Add support for multiple workspaces Jul 17, 2019
@ccordoba12 ccordoba12 merged commit f7380af into palantir:develop Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants