Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable parent process checking for TCP server #642

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Enable parent process checking for TCP server #642

merged 3 commits into from
Sep 2, 2019

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Aug 30, 2019 •
edited
Loading

Allow to shutdown pyls if TCP mode is active and the parent process reported by the $/initialized call is killed.

@andfoy andfoy mentioned this pull request Aug 30, 2019
Merged
@ccordoba12 ccordoba12 added this to the 0.29.0 milestone Aug 30, 2019
ccordoba12
ccordoba12 reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment, otherwise looks good.

pyls/python_ls.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Enable parent process checking for TCP server Enable parent process checking for TCP server Sep 2, 2019
@ccordoba12 ccordoba12 merged commit f759af2 into palantir:develop Sep 2, 2019
@andfoy andfoy deleted the fix_exit_tcp branch September 2, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andfoy @ccordoba12