Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion tests for several libraries of the Scientific Python stack #682

Merged
merged 3 commits into from
Oct 27, 2019

Conversation

ccordoba12
Copy link
Contributor

This will allow us to verify that Jedi doesn't break completions for libraries like Numpy, Pandas and Matplotlib (the ones tested here).

@ccordoba12 ccordoba12 added this to the 0.29.2 milestone Oct 23, 2019
@ccordoba12
Copy link
Contributor Author

ccordoba12 commented Oct 23, 2019

@gatesn, this clearly shows that Jedi 0.15 broke completions for those libraries, which we discovered when we tried to update our Spyder dependency on the python-language-server to use version 0.29.

Therefore, I'm considering to push a new PR that adds back support for Jedi 0.14.1, along with 0.15, to have a python-language-server that works for Numpy, Pandas, etc. And on the Spyder side we'd demand 0.14.1 to have the version that we really need.

This is my plan because I think we can't demand Jedi <0.15 here again due to 0.29+ being already packaged by several Linux distros (e.g. Arch).

Please let me know if you think there's a better way to handle this very ugly situation. If I don't hear from you by tomorrow, I'll continue with this plan because it's critical for us to start using 0.29+ due to the PRs submitted by our team (#680, #665, #655 and more to come).

@ccordoba12 ccordoba12 merged commit f619d3a into palantir:develop Oct 27, 2019
@ccordoba12 ccordoba12 deleted the test-scipy-packages branch October 27, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant