Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] Try building against java 12 #135

Closed
wants to merge 6 commits into from
Closed

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Apr 10, 2019

Internally, we're pushing all our services to run on Java11 only as it's a nice LTS release.

For libraries however, we want to keep testing against Java8 to make sure we don't break backwards compatibility. Given we have to keep the java 8 CI, I think we might as well start testing against Java 12, so hopefully we can catch any tooling gotchas early.

cc @robert3005

@iamdanfox iamdanfox requested a review from a team as a code owner April 10, 2019 22:12
build.gradle Outdated
apply plugin: 'com.palantir.baseline-scalastyle'
apply plugin: 'com.palantir.baseline-eclipse'
apply plugin: 'com.palantir.baseline-idea'
// apply plugin: 'com.palantir.baseline-error-prone'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's a known issue that error-prone 2.3.3 doesn't work with Java 12: google/error-prone#1106

@@ -67,5 +67,6 @@ subprojects {

tasks.withType(JavaCompile) {
options.compilerArgs += ['-Xlint:deprecation', '-Werror']
options.errorprone.errorproneArgs += '-Xep:Finally:OFF'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just tried this on a much larger internal project (SMM) and errorprone passed nicely when I turned off this single rule!

@gm2211
Copy link

gm2211 commented Jun 12, 2019

Adding to this, another large internal project (ICS server) has source 11 and compiling with jdk11 is super slow, but it's really fast with jdk12 (think 3+ minutes in jdk11 and < 20 seconds in jdk12). Can use jdk12 fine in intellij, but it fails in gradle with:

     Please report this at https://github.com/google/error-prone/issues/new and include the following:

     error-prone version: 2.3.3
     BugPattern: Finally
     Stack Trace:
     java.lang.NoSuchFieldError: label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants