Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Deprecate typeof-compare #2187

Closed
ajafff opened this issue Feb 7, 2017 · 0 comments · Fixed by #3286
Closed

Deprecate typeof-compare #2187

ajafff opened this issue Feb 7, 2017 · 0 comments · Fixed by #3286

Comments

@ajafff
Copy link
Contributor

ajafff commented Feb 7, 2017

microsoft/TypeScript#13791 has just landed in typescript. This changes typeof to return a union of string literal types.

When this change is shipped with the next release of typescript, the rule typeof-compare can be deprecated. The compiler will then catch comparisons with invalid strings.

@ajafff ajafff mentioned this issue Oct 5, 2017
4 tasks
DanielKucal added a commit to DanielKucal/tslint-angular that referenced this issue Jan 17, 2018
typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant.
palantir/tslint#2187
mgechev pushed a commit to mgechev/tslint-angular that referenced this issue Jan 17, 2018
typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant.
palantir/tslint#2187
waitingsong added a commit to waitingsong/angular-realworld-example-app that referenced this issue Feb 5, 2018
Toxicable pushed a commit to gothinkster/angular-realworld-example-app that referenced this issue Mar 6, 2018
* fix(tslint):  comment must start with a space

* fix(tslint): selector of the directive "ShowAuthedDirective" should have prefix "app"

* chore(tslint): remove deprecated rule of typeof-compare

palantir/tslint#2187

* chore(deps): update devDependency ts-node to v4.1.0

* chore(deps): update devDependency tslint to v5.9.1

* chore(deps): update devDependency @types/node to latest

* chore(deps): update devDependency typescript to v2.6.2
newsum2019 added a commit to newsum2019/angular-realworld-example-app that referenced this issue Oct 6, 2019
* fix(tslint):  comment must start with a space

* fix(tslint): selector of the directive "ShowAuthedDirective" should have prefix "app"

* chore(tslint): remove deprecated rule of typeof-compare

palantir/tslint#2187

* chore(deps): update devDependency ts-node to v4.1.0

* chore(deps): update devDependency tslint to v5.9.1

* chore(deps): update devDependency @types/node to latest

* chore(deps): update devDependency typescript to v2.6.2
starhelios pushed a commit to starhelios/angular7-typescript-project that referenced this issue Jun 1, 2020
* fix(tslint):  comment must start with a space

* fix(tslint): selector of the directive "ShowAuthedDirective" should have prefix "app"

* chore(tslint): remove deprecated rule of typeof-compare

palantir/tslint#2187

* chore(deps): update devDependency ts-node to v4.1.0

* chore(deps): update devDependency tslint to v5.9.1

* chore(deps): update devDependency @types/node to latest

* chore(deps): update devDependency typescript to v2.6.2
starhelios added a commit to starhelios/angular7-typescript-project that referenced this issue Jun 1, 2020
* fix(tslint):  comment must start with a space

* fix(tslint): selector of the directive "ShowAuthedDirective" should have prefix "app"

* chore(tslint): remove deprecated rule of typeof-compare

palantir/tslint#2187

* chore(deps): update devDependency ts-node to v4.1.0

* chore(deps): update devDependency tslint to v5.9.1

* chore(deps): update devDependency @types/node to latest

* chore(deps): update devDependency typescript to v2.6.2
davidc05 added a commit to davidc05/angular-quick-app that referenced this issue Jul 20, 2020
* fix(tslint):  comment must start with a space

* fix(tslint): selector of the directive "ShowAuthedDirective" should have prefix "app"

* chore(tslint): remove deprecated rule of typeof-compare

palantir/tslint#2187

* chore(deps): update devDependency ts-node to v4.1.0

* chore(deps): update devDependency tslint to v5.9.1

* chore(deps): update devDependency @types/node to latest

* chore(deps): update devDependency typescript to v2.6.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant