Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

deprecate typeof-compare #3286

Merged
merged 2 commits into from
Oct 19, 2017
Merged

deprecate typeof-compare #3286

merged 2 commits into from
Oct 19, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Oct 5, 2017

PR checklist

Overview of change:

Show a deprecation warning if the rule is used with typescript 2.2 or newer.
That allows us to remove this rule when we drop support for typescript@2.1
Fixes: #2187
Closes: #2066

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[deprecation] typeof-compare is deprecated because typescript already does that check

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate typeof-compare improve typeof-compare error message to contain the failing word and a suggestion
2 participants