Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Updated version of commander.js package #3510

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Updated version of commander.js package #3510

merged 1 commit into from
Nov 28, 2017

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Nov 23, 2017

PR checklist

Changelog

[bugfix] Update commander.js dependency to prevent users from transitively installing a buggy 2.12.0 release

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @timocov! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

How about bumping the minimum dep to 2.12.1 instead? tj/commander.js@a7124fc

@timocov timocov changed the title Frozen commander.js package version to 2.9.0 Updated version of commander.js package Nov 28, 2017
@timocov
Copy link
Contributor Author

timocov commented Nov 28, 2017

@adidahiya sure. I have updated pr.

package.json Outdated
@@ -56,7 +56,7 @@
"devDependencies": {
"@types/babel-code-frame": "^6.20.0",
"@types/chai": "^3.5.0",
"@types/commander": "^2.9.0",
"@types/commander": "^2.11.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this now that the package contains declaration files?

Copy link
Contributor Author

@timocov timocov Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed @types package

@adidahiya adidahiya merged commit 21aa184 into palantir:master Nov 28, 2017
@timocov timocov deleted the fix3509 branch November 28, 2017 11:33
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants