[New rule] add fileNameCasing rule #3978
Conversation
|
Thanks for your interest in palantir/tslint, @euclio! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
euclio
force-pushed
the
file-name-casing
branch
3 times, most recently
from
1721259
to
b8dc933
Compare
src/rules/fileNameCasingRule.ts
Outdated
|
|
||
| const casing = this.ruleArguments[0] as Casing; | ||
|
|
||
| let isCorrectCasing = true; |
There was a problem hiding this comment.
refactor: make a private isCorrectCasing(fileName) function that returns a boolean in each switch case instead of declaring a let variable.
| case Casing.KebabCase: | ||
| return isKebabCased(fileName); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: blank line between function members.
| enum Casing { | ||
| CamelCase = "camel-case", | ||
| PascalCase = "pascal-case", | ||
| KebabCase = "kebab-case", |
There was a problem hiding this comment.
🤔 camelCase, PascalCase, kebab-case? weird to write them all in kebab case. this comment is inspired by the error message:
File name must be camel-cased. vs File name must be camelCased.
There was a problem hiding this comment.
i think i'm into the string matching the expected casing.
There was a problem hiding this comment.
I can change the error message, but I think that the option names should stay kebab-cased for consistency with other rule options.
|
@giladgray Awesome, thanks! Could you go ahead and close #3434? Looks like it didn't close automatically. |
* add fileNameCasing rule * use camel case name for tslintCli * refactor casing check into helper function * use stylized name for casing in failure message
|
Getting Version 5.10.0 |
|
@tommedema This lint hasn't been included in a release yet |
PR checklist
Overview of change:
Creates a new fileNameCasing rule that ensures consistent casing for all file names.
CHANGELOG.md entry:
[new-rule] file-name-casing