Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Better support for globs in cli #827

Merged
merged 1 commit into from
Dec 6, 2015
Merged

Conversation

louy
Copy link
Contributor

@louy louy commented Nov 28, 2015

Related to #692. Potentially fixed glob issues in windows.

This makes the cli accept a glob as a string and expand it.

It solves a problem with "arguments list is too large" when using regular globs.

@louy
Copy link
Contributor Author

louy commented Nov 28, 2015

@adidahiya I think I'll add support for directories using a glob pattern "[directory]/*/.ts" for all passed directories. What do you think?

@adidahiya
Copy link
Contributor

I don't see a need for automatically expanding directory paths into globs, so what you have here looks fine.

If your shell supports globs, wouldn't it still expand them though? How would you get around the "argument list is too large" issue? Would you have to provide a glob path as a string?

tslint 'src/**/*.ts'

@louy
Copy link
Contributor Author

louy commented Dec 1, 2015

Yeah you'll have to provide the path as a string. However, I'm planing to accept directories and convert them to a glob like "[directory]/**.ts". this will be done in a separate PR, so in the future you'll be able to do tslint . or tslint src/ and it will walk through all .ts files in that directory.

@adidahiya
Copy link
Contributor

@louy cool, I like the idea of adding support for directories in a separate PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants