Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Better support for linting multiple files #692

Closed
1 of 2 tasks
adidahiya opened this issue Sep 28, 2015 · 9 comments
Closed
1 of 2 tasks

Better support for linting multiple files #692

adidahiya opened this issue Sep 28, 2015 · 9 comments

Comments

@adidahiya
Copy link
Contributor

Related: #680

@Pajn
Copy link
Contributor

Pajn commented Oct 10, 2015

Q: should we ignore .d.ts files by default? and provide an option to opt-in to linting them?

Yes please. Getting lint errors because the typings from tsd doesn't follow the same code standard as the project would be pretty messy.
An opt-out would work as well, but I think the most common would be to not wanting to lint .d.ts files.

@adidahiya adidahiya modified the milestones: TSLint 3.0, TSLint 4.0 Oct 14, 2015
@raveclassic
Copy link

TSLint should lint all the files listed in the "files"

Are you going to support filesGlob and exclude from tsconfig as well as files?
This would be very helpful, as it is wierd and close to impossible to define all the sources in files in large projects.

@jkillian
Copy link
Contributor

@raveclassic Definitely want to support filesGlob and exclude. Without those things are significantly more painful

@raveclassic
Copy link

@jkillian Thanks, waiting for changes. For now will use gulp to gather the files.
Besides, great work guys!

@ghost
Copy link

ghost commented Nov 11, 2015

I wonder what's the benefit of merging multiple reports into one... I think that three (relatively) small issues have a greater chance to be implemented than one big issue. But sure, it's up to you how you manage your project...

@louy
Copy link
Contributor

louy commented Dec 6, 2015

I have an unfinished solution for task 2 and #680 in here. I don't have enough time to finish it so if anyone would like to step in feel free to do so.

BTW, after #857 is merged I feel that this one should be closed. Task 2 isn't relevant here.

louy added a commit to louy/tslint that referenced this issue Dec 6, 2015
@adidahiya
Copy link
Contributor Author

moved task 2 (tsconfig.json support) to #858

@unional
Copy link
Contributor

unional commented Mar 21, 2016

I agree with ignoring .d.ts files by default

Please do not do that, at least not hard coding that. Using tslint to lint .d.ts for typings.

@adidahiya
Copy link
Contributor Author

No one is really pining for directories support (first checklist item in the issue description) so it seems like globs are enough. Closing this out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants